Add missing react_render_core -> runtimeexecutor CMake dep#43028
Closed
motiz88 wants to merge 1 commit into
Closed
Add missing react_render_core -> runtimeexecutor CMake dep#43028motiz88 wants to merge 1 commit into
motiz88 wants to merge 1 commit into
Conversation
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D53767182 |
Summary: Changelog: [Internal] Should fix an OSS Android build failure introduced in the stack of D53671483. (Apparently CMake doesn't propagate transitive header dependencies?) Reviewed By: robhogan Differential Revision: D53767182
3960884 to
62b2011
Compare
Base commit: 496724f |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D53767182 |
Contributor
|
This pull request has been merged in 3020747. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
Should fix an OSS Android build failure introduced in the stack of D53671483. (Apparently CMake doesn't propagate transitive header dependencies?)
Differential Revision: D53767182